feat(Search): add Find button #5790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 26be94a:
|
e2e tests |
👀 Docs deployed
Commit 26be94a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5790 +/- ##
==========================================
+ Coverage 79.38% 79.40% +0.01%
==========================================
Files 306 306
Lines 9631 9639 +8
Branches 3261 3265 +4
==========================================
+ Hits 7646 7654 +8
Misses 1985 1985
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Sep 14, 2023
github-actions
bot
added
the
pr-needs-work
BlackySoul
added
no-stale
BlackySoul
force-pushed
the
feat/5521/Search_add_find_button
branch
from
8be7488 to
26be94a
Compare
inomdzhon
approved these changes
Nov 16, 2023
mendrew
approved these changes
Nov 16, 2023
vkcom-publisher
pushed a commit
that referenced
this pull request
Nov 20, 2023
* feat(Search): add Find button * fix(Search): remove absolute position + code style fixes * fix(Search): fix test get buttons func * feat(Search): mv appear/disappear logic of controls to CSS * fix(Search): fix flicking on Safari * feat(Search): add find button * chore: update screenshots --------- Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve [Feature]: Добавить параметр отображения кнопки «Найти» в компоненте Search #5521
Unit-тесты
e2e-тесты
Дизайн-ревью
Описание
Добавляем кнопку "Найти" в соответствии с требованиями дизайн-системы