Fix ModalDismissButton appearance in the doc #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button dissapeared from the screen after b5aa644 Because we started to rely on the .PopoutWrapper__content position relative, but the with of PopoutWrapper is the whole screen.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f224dd:
|
👀 Docs deployed
Commit 6f224dd |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5764 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 298 298
Lines 9839 9839
Branches 3115 3115
=======================================
Hits 8067 8067
Misses 1772 1772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
added
ci:cherry-pick:patch
SevereCloud
approved these changes
Sep 11, 2023
inomdzhon
approved these changes
Sep 11, 2023
inomdzhon
deleted the
origin/mendrew/fix-modal-dismiss-button-example
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 11, 2023
The button dissapeared from the screen after b5aa644 Because we started to rely on the .PopoutWrapper__content position relative, but the with of PopoutWrapper is the whole screen.
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 11, 2023
The button dissapeared from the screen after b5aa644 Because we started to rely on the .PopoutWrapper__content position relative, but the with of PopoutWrapper is the whole screen.
|
✅ v5.8.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Кнопка пропала из документации https://vkcom.github.io/VKUI/#/ModalDismissButton
Пропажа связана с
b5aa644
потому что мы стали полагаться на
position: relativePopoutWrapper__content, но в примере он имеет ширину на всю страницу.Вернул position: relative в пример.
Изображения
До
После
