Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Carousel): add Gallery with loop #5744

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Sep 4, 2023

Создала отдельным компонентом, потому что пришлось переделать механизм "пролистывания" слайда, чтобы не заафектить уже работающую BaseGallery
К v6 переедем на общий механизм

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa883d3:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

size-limit report 📦

Path Size
JS 322.69 KB (+1.82% 🔺)
JS (gzip) 98.17 KB (+1.54% 🔺)
JS (brotli) 81.4 KB (+1.74% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 278.44 KB (0%)
CSS (gzip) 36.1 KB (0%)
CSS (brotli) 28.62 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

👀 Docs deployed

Commit aa883d3

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Attention: 252 lines in your changes are missing coverage. Please review.

Comparison is base (a1bb600) 81.19% compared to head (aa883d3) 79.16%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5744      +/-   ##
==========================================
- Coverage   81.19%   79.16%   -2.04%     
==========================================
  Files         299      303       +4     
  Lines        9191     9482     +291     
  Branches     3122     3208      +86     
==========================================
+ Hits         7463     7506      +43     
- Misses       1728     1976     +248     
Flag Coverage Δ
unittests 79.16% <12.19%> (-2.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/components/BaseGallery/CarouselBase/constants.ts 100.00% <100.00%> (ø)
packages/vkui/src/components/Gallery/Gallery.tsx 97.29% <100.00%> (+0.52%) ⬆️
packages/vkui/src/lib/fx.ts 20.00% <25.00%> (+20.00%) ⬆️
packages/vkui/src/lib/animate.ts 5.55% <0.00%> (-2.14%) ⬇️
...i/src/components/BaseGallery/CarouselBase/hooks.ts 31.25% <31.25%> (ø)
...src/components/BaseGallery/CarouselBase/helpers.ts 1.58% <1.58%> (ø)
...mponents/BaseGallery/CarouselBase/CarouselBase.tsx 9.44% <9.44%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul force-pushed the feat/5264/Gallery_add_loop branch from 568944f to 73941ba Compare September 4, 2023 16:44
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

кек, сам CarouselBase я ведь не посмотрел x)) из-за того, что в интерфейсе он по-умолчанию был скрыт 🌚

пока вот такие комменты, ещё гляну собственно CarouselBase

@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 6, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 14, 2023
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... конечно, колоссальная работа 😲😲😲

предложил некоторые правки по код стайлу

логика нетривиальна, поэтому с ходу пока не могу прокомментировать, буду ждать вынесение части функций, чтобы для восприятия легче стало

@BlackySoul BlackySoul force-pushed the feat/5264/Gallery_add_loop branch from 4a9a581 to 2410865 Compare September 15, 2023 05:04
@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 15, 2023
@github-actions github-actions bot added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Sep 22, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Согласен, грандиозная работа. 💯

Блокирующий только вопрос по функции getShiftedIndexes, остальное опционно.

@BlackySoul BlackySoul force-pushed the feat/5264/Gallery_add_loop branch from 70e9fa1 to 8306a12 Compare September 29, 2023 11:48
@BlackySoul BlackySoul requested a review from mendrew September 29, 2023 11:49
mendrew
mendrew previously approved these changes Oct 2, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Спасибо!

SevereCloud
SevereCloud previously approved these changes Oct 2, 2023
@BlackySoul BlackySoul dismissed stale reviews from SevereCloud and mendrew via aa883d3 October 2, 2023 13:25
@BlackySoul BlackySoul merged commit da9206a into master Oct 2, 2023
@BlackySoul BlackySoul deleted the feat/5264/Gallery_add_loop branch October 2, 2023 14:07
vkcom-publisher pushed a commit that referenced this pull request Oct 2, 2023
* feat(Carousel): add Gallery with loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Добавить возможность работы Gallery как карусель
4 participants