Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Image): width & height #5682

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat(Image): width & height #5682

merged 1 commit into from
Oct 11, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Aug 22, 2023 •
edited
Loading

@SevereCloud SevereCloud force-pushed the SevereCloud/feat/Image/width-&-height branch 2 times, most recently from 1d0f7ba to 92bdfd0 Compare August 22, 2023 15:32
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 22, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f8c729f:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
JS 326.97 KB (+0.07% 🔺)
JS (gzip) 99.34 KB (+0.09% 🔺)
JS (brotli) 82.18 KB (+0.06% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.09 KB (0%)
CSS (gzip) 33.49 KB (0%)
CSS (brotli) 27.17 KB (0%)

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 92bdfd0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023 •
edited
Loading

e2e tests

Playwright Report

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 30, 2023
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 6, 2023
@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 7, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 14, 2023
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/Image/width-&-height branch from 92bdfd0 to e8d3a43 Compare September 19, 2023 15:26
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited
Loading

👀 Docs deployed

Commit f8c729f

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (71e3796) 79.19% compared to head (f8c729f) 79.21%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5682      +/-   ##
==========================================
+ Coverage   79.19%   79.21%   +0.02%     
==========================================
  Files         304      305       +1     
  Lines        9515     9528      +13     
  Branches     3217     3220       +3     
==========================================
+ Hits         7535     7548      +13     
  Misses       1980     1980
Flag Coverage Δ
unittests 79.21% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/vkui/src/components/Avatar/Avatar.tsx 100.00% <ø> (ø)
...ckages/vkui/src/components/ImageBase/ImageBase.tsx 93.10% <100.00%> (+0.51%) ⬆️
packages/vkui/src/components/ImageBase/helpers.ts 47.36% <ø> (ø)
packages/vkui/src/lib/comparing.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud marked this pull request as ready for review September 19, 2023 15:34
@SevereCloud SevereCloud requested a review from a team as a code owner September 19, 2023 15:34
@SevereCloud SevereCloud removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 19, 2023
mendrew
mendrew previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 5, 2023
@BlackySoul
Copy link
Contributor

А у нас, например, есть экспортируемая функция getOverlayIconSizeByImageBaseSize, в ней логика для прямоугольных изображений должна быть поддержана?

@SevereCloud
Copy link
Contributor Author

А у нас, например, есть экспортируемая функция getOverlayIconSizeByImageBaseSize, в ней логика для прямоугольных изображений должна быть поддержана?

Туда по сути нужно передавать наименьшую сторону, поэтому не вижу проблем

@BlackySoul
Copy link
Contributor

BlackySoul commented Oct 6, 2023 •
edited
Loading

А у нас, например, есть экспортируемая функция getOverlayIconSizeByImageBaseSize, в ней логика для прямоугольных изображений должна быть поддержана?

Туда по сути нужно передавать наименьшую сторону, поэтому не вижу проблем

В jsdoc не нужно инфу докинуть?

border-radius, получается, тоже по наименьшей из сторон определяется?

BlackySoul
BlackySoul previously approved these changes Oct 6, 2023
View reviewed changes
@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 7, 2023
@SevereCloud SevereCloud dismissed stale reviews from BlackySoul and mendrew via f8c729f October 10, 2023 08:22
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/Image/width-&-height branch from e8d3a43 to f8c729f Compare October 10, 2023 08:22
@SevereCloud SevereCloud requested a review from mendrew October 10, 2023 08:24
@SevereCloud
Copy link
Contributor Author

Конфликты, ребейснул

В jsdoc не нужно инфу докинуть?

Докинул

border-radius, получается, тоже по наименьшей из сторон определяется?

Да

mendrew
mendrew approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@SevereCloud SevereCloud merged commit 6e5cfb0 into master Oct 11, 2023
@SevereCloud SevereCloud deleted the SevereCloud/feat/Image/width-&-height branch October 11, 2023 08:22
vkcom-publisher pushed a commit that referenced this pull request Oct 11, 2023
@SevereCloud @actions-user
feat(Image): widthSize & heightSize (#5682)
f09f0e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendrew mendrew mendrew approved these changes

@BlackySoul BlackySoul BlackySoul approved these changes

@inomdzhon inomdzhon Awaiting requested review from inomdzhon

Assignees
No one assigned
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Прямоугольные Image
4 participants
@SevereCloud @BlackySoul @mendrew @inomdzhon