Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Header): update margins #5681

Merged
merged 1 commit into from
Sep 18, 2023
Merged

feat(Header): update margins #5681

merged 1 commit into from
Sep 18, 2023

Conversation

@SevereCloud SevereCloud requested a review from a team as a code owner August 22, 2023 15:25
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e26c54:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 315.72 KB (-0.01% 🔽)
JS (gzip) 93.01 KB (+0.01% 🔺)
JS (brotli) 76.86 KB (-0.07% 🔽)
JS import Div (tree shaking) 3.04 KB (0%)
CSS 275.63 KB (-0.08% 🔽)
CSS (gzip) 36 KB (-0.04% 🔽)
CSS (brotli) 28.53 KB (-0.12% 🔽)

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 9e26c54

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07% ⚠️

Comparison is base (52b54b1) 81.97% compared to head (9e26c54) 81.90%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5681      +/-   ##
==========================================
- Coverage   81.97%   81.90%   -0.07%     
==========================================
  Files         295      296       +1     
  Lines        9806     9764      -42     
  Branches     3095     3094       -1     
==========================================
- Hits         8038     7997      -41     
+ Misses       1768     1767       -1     
Flag Coverage Δ
unittests 81.90% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/Header/Header.tsx 96.29% <100.00%> (-0.14%) ⬇️

... and 80 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 2, 2023
@BlackySoul
Copy link
Contributor

Кажется, нужно ревью дизайнеров х)

Например, вариант title + subtitle должен быть 60px в высоту?

@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 5, 2023
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 6, 2023
@SevereCloud SevereCloud requested a review from a team September 7, 2023 06:24
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 14, 2023
@SevereCloud
Copy link
Contributor Author

Например, вариант title + subtitle должен быть 60px в высоту?

А он 60px, просто адаптивность меняет высоту шрифта

image

@SevereCloud SevereCloud removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 14, 2023
Copy link

@Zaycevq Zaycevq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@SevereCloud SevereCloud merged commit 12d9a00 into master Sep 18, 2023
@SevereCloud SevereCloud deleted the SevereCloud/issue466 branch September 18, 2023 11:35
vkcom-publisher pushed a commit that referenced this pull request Sep 18, 2023
@SevereCloud SevereCloud mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
4 participants