Closed
Conversation
Изменения в `reusable_workflow_test_e2e.yml`: - Используем `strategy.matrix` и `--shard` для распараллеливания джоб. - Удалили загрузку артефакта `e2e-output` за ненадобностью. - Удалили `TODO Playwright реализовать покрытие`, т.к. покрытие мы уже собираем jest'ом. Изменения в `playwright-ct.config.ts`: - Так как в CI мы распараллеливаем тесты через `--shard`, то ставим `workers` на 1 для разгрузки каждой из 10 джоб. - Пробуем выставить `maxFailures: 10` в CI, чтобы в лишний раз не гонять все тесты, если 10 из них упали.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b5c7b70:
|
Contributor
👀 Docs deployedCommit b5c7b70 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5308 +/- ##
=======================================
Coverage 81.72% 81.72%
=======================================
Files 283 283
Lines 9474 9474
Branches 2933 2933
=======================================
Hits 7743 7743
Misses 1731 1731
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Не так понял как работает сочетание `strategy.matrix` с `--shard` в Playwright.
inomdzhon
force-pushed
the
imirdzhamolov/issue5306/ci/playwright-parallelism
branch
from
6d8b5df to
56af7d7
Compare
inomdzhon
force-pushed
the
imirdzhamolov/issue5306/ci/playwright-parallelism
branch
from
56af7d7 to
b5c7b70
Compare
github-actions
bot
added
the
pr-needs-work
Contributor
|
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
inomdzhon
restored the
imirdzhamolov/issue5306/ci/playwright-parallelism
branch
inomdzhon
removed
the
pr-needs-work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения в
reusable_workflow_test_e2e.yml:strategy.matrixи--shardдля распараллеливания джоб.shardTotal10 исходя из того, что у нас 10 проектов запускается вplaywright-ct.config.ts.e2e-outputза ненадобностью.TODO Playwright реализовать покрытие, т.к.покрытие мы уже собираем jest'ом.
Изменения в
playwright-ct.config.ts:--shard, тоставим
workersна 1 для разгрузки каждой из 10 джоб.maxFailures: 10в CI, чтобы в лишний раз не гонятьвсе тесты, если 10 из них упали.
reusable_workflow_test_e2e.yml#5306