Product category (version with the corrections) #95
Conversation
|
Am I right, and your pull request contains only the definition of ProductCategoryStructure and not its usage? |
Now all data is committed to this branch.
|
You are right, but it was not intended. Updated the rest now. |
|
Sorry, now you screwed OJP_commons.xsd completely up. |
|
you are right. But how? I edited it directly in github. It looks even ok in the comparison |
|
It's still there. You removed OJP_commons.xsd and added an OJP_commons.xsd.tmp. |
|
I used the github inline editor, which obviously doesn't do what it should. And we currently seem to try to outcommit each other 👍 |
|
Now, it looks good to me. |
OJP_JourneySupport.xsd
Outdated
| @@ -58,6 +80,11 @@ | |||
| <xs:documentation>[a specialisation of MODE in TMv6] an extended range of VEHICLE MODEs, aggregating them with some SUBMODEs</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:element> | |||
| <xs:element name="ProductCategory" type="ProductCategoryStructure"> | |||
| <xs:annotation> | |||
| <xs:documentation>A product category for the service.</xs:documentation> | |||
|
In general ok
|
More descriptive text.
OJP_JourneySupport.xsd
Outdated
| @@ -23,22 +23,22 @@ | |||
| </xs:complexType> | |||
| <xs:complexType name="ProductCategoryStructure"> | |||
| <xs:annotation> | |||
| <xs:documentation>Product category based on NeTEx</xs:documentation> | |||
| <xs:documentation>Product category based on NeTEx. A product category is a classification to particular VEHICLE JOURNEYs to express some common properties of journeys form marketing and fare products. </xs:documentation> | |||
There was a problem hiding this comment.
Should be journeys for marketing and fare products (for instead of form)
OJP_Common.xsd
Outdated
| @@ -95,7 +95,7 @@ | |||
| </xs:simpleType> | |||
| <xs:element name="ProductCategoryRef" type="siri:ProductCategoryRefStructure"> | |||
| <xs:annotation> | |||
| <xs:documentation>Reference to a product category.</xs:documentation> | |||
| <xs:documentation>Reference to a product category. It is useful to use the same types that are also used in time tables and real time data.</xs:documentation> | |||
There was a problem hiding this comment.
What is meant by "types" here?
There was a problem hiding this comment.
Changed the text to
Reference to a product category. The product categories should be defined and used in a general manner over all channels (e.g. NeTEx, Siri, OJP)
OJP_JourneySupport.xsd
Outdated
| </xs:annotation> | ||
| </xs:element> | ||
| <xs:element name="ShortName" type="InternationalTextStructure" minOccurs="0"> | ||
| <xs:annotation> | ||
| <xs:documentation>Short name or acronym of product category.</xs:documentation> | ||
| <xs:documentation>Short name or acronym of product category. If you intend to publish the product category, this is were you would put, the information that you want to associate with the journey. E.g. "ARZ" in Switzerland or "BAV".</xs:documentation> |
There was a problem hiding this comment.
What is meant by this is were you would put, the information that you want to associate with the journey?
There was a problem hiding this comment.
changed to: hort name or acronym of product category. The short name will likely be published. E.g. the product category is more important for publication in Switzerland than Mode / Submode. Examples "BAV", "ARZ", "TGV"
Messed up with desktop git, so new pull request