Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarifying the usage of coord and addresses in the stop event service #412

Merged
merged 4 commits into from
Oct 16, 2023
Merged

clarifying the usage of coord and addresses in the stop event service #412

merged 4 commits into from
Oct 16, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Oct 11, 2023

fixes #407

@ue71603 ue71603 added this to the v2.0 milestone Oct 11, 2023
herlitze
herlitze reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@herlitze herlitze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the next stop being always shown. If no stop is reached within range of limitations , I would not expect a result.

ue71603
ue71603 commented Oct 12, 2023
View reviewed changes
OJP/OJP_StopEvents.xsd Outdated Show resolved Hide resolved
herlitze
herlitze previously approved these changes Oct 12, 2023
View reviewed changes
@skinkie
Copy link
Contributor

skinkie commented Oct 12, 2023

@herlitze don't approve if you have open comments ;-)

@herlitze
Copy link
Contributor

@herlitze don't approve if you have open comments ;-)

Oh, you are right Matthias' suggested change is not part of the commit yet.

@herlitze @ue71603
Apply suggestions from code review
42bdad8 
Co-authored-by: Matthias Günter <[email protected]>
herlitze
herlitze previously approved these changes Oct 12, 2023
View reviewed changes
@skinkie skinkie merged commit bea8101 into changes_for_v1.1 Oct 16, 2023
@skinkie skinkie deleted the clarifyingcoordinatesinstopeventrequest branch October 16, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl approved these changes

@skinkie skinkie skinkie approved these changes

@herlitze herlitze herlitze left review comments

@Aurige Aurige Awaiting requested review from Aurige

@sgrossberndt sgrossberndt Awaiting requested review from sgrossberndt

@normanoffel normanoffel Awaiting requested review from normanoffel

Assignees
No one assigned
Labels
doc updated documentation
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ue71603 @skinkie @herlitze @trurlurl