implementing MODES OF OPERATION from FU 44 #379

ue71603 · 2023-07-03T22:01:04Z

Additionally, The association from NAVIGATION PATH to ACCESS MODE should be removed and replaced with an association between NAVIGATION PATH and PERSONAL MODE.

Maybe:
NAVIGATION PATH --> traversable by --> PERSONAL MODE
PERSONAL MODE --> suitable for --> NAVIGATION PATH

Current state of affairs

List in Transmodel
dynamicCarPooling
longDistanceCarPooling
stationlessVehicleSharing
peerToPeerCarSharing
taxicab
sharedTaxi
commercialCarSharing
carSharingClub
cycleSharing
chauffeuredCar
taxi

netex_modeOfOperation_support

Modes of Operation:
scheduled
flexible
alternative
vehicleRental
vehicleSharing
vehiclePooling
personal
other

Enums of SubModesOfOperation:

flexible
<xsd:enumeration value="flexibleRoute"/>
<xsd:enumeration value="flexibleArea"/>
<xsd:enumeration value="demandResponsive"/>
rental:
<xsd:enumeration value="vehicleHire"/>
<xsd:enumeration value="vehicleLease"/>
sharing:
<xsd:enumeration value="carSharingClub"/>
<xsd:enumeration value="peerToPeerCarSharing"/>
<xsd:enumeration value="vehicleSharing"/>
pooling
<xsd:enumeration value="taxi"/>
<xsd:enumeration value="appBookedTaxi"/>
<xsd:enumeration value="sharedTaxi"/>
<xsd:enumeration value="prebookedTaxi"/>
<xsd:enumeration value="chaffeuredVehicle"/>
<xsd:enumeration value="dynamicCarPooling"/>
<xsd:enumeration value="longDistanceCarPooling"/>
personal
<xsd:enumeration value="commuterCarPooling"/>
<xsd:enumeration value="ownCar"/>
<xsd:enumeration value="privateLift"/>
scheduled
<xsd:enumeration value="scheduledService"/>
<xsd:enumeration value="eventBasedService"/>

OJP/OJP_ModesSupport.xsd

ue71603 · 2023-07-08T16:23:08Z

Things we don't want to do are now in: #380

herlitze

We have to wait for our discussion and the solution for demandResponsive

OJP/OJP_ModesSupport.xsd

Aurige

Sorry I'm late to this discussion, and try to catch-up

To Malte: demandResponsive is not always Continuous; for example Virtual Lines are demandResponsive and have schedules. You can't really link them as both situation occur. And to me that sounds really weird to mess the category just because the attribute we need (GeoPosition) is only in one of these categories.

One other thing I find a bit confusing is that IndividualModesOfOperationEnumeration and PrivateModesEnumeration ere in fact compbinations of (vehicle)mode and mode of operation. Also in PrivateModesEnumeration we have things like taxi/appBookedTaxi/sharedTaxi/prebookedTaxi but a single taxi service (mode of operation) can offer all these services (plus hailed taxi, but I guess that this is the "taxi" value), so we are mixing the mode of operation and the booking&service description.

I know that the NeTEx MODEs are far from perfect and often blurry, but I have the feeling that we are replacing a blurry sition by another blurry one.

OJP/OJP_ModesSupport.xsd

Aurige · 2023-09-05T09:18:24Z

OJP/OJP_ModesSupport.xsd

 		</xs:annotation>
 		<xs:restriction base="xs:string">
 			<xs:enumeration value="walk"/>
+			<xs:enumeration value="commuterCarPooling">


Why is this Continuous: there is most often a scheduled pick up time !

@Aurige comes with the pickup being a PLACE and not a SITE ELEMENT. We don't have the tools for that in OJP. So perhaps you want to weight in on that. Perhaps we need to have some enum values in both enumerations "demandresponsive" for TimedLeg (line based) and ContinuousLeg (for area non-stop based). This might also be true for commutercarPooling. Should I update accordingly?

OJP/OJP_ModesSupport.xsd

ue71603 · 2023-09-15T09:35:22Z

@trurlurl @herlitze @normanoffel @Aurige :
What we need to do next week:

Check that we added the things from Transmodel FU44 to the definitions in OJP. Christophe/Matthias
Make clear that we will only have SITE ELEMENTS in TimedLegs => area based door-2-door demand responsive buses are ContinuousLegs
Cleanup the enums (I think they are currently not clear cut)

ue71603 · 2023-09-19T12:17:39Z

MODE_OF_OPERATION.xlsx
@skinkie @herlitze @normanoffel @Aurige @sgrossberndt @trurlurl
I tried to map MODE OF OPERATION, MODE and all the rest into one consistent picture:

We keep TimedLeg, TransferLeg, ContinuousLeg
We have a ModeOfOperation (which bases on xxxService currently). There are many and they may affect, which MODE / SUBMODE can then be used. But we don't explicitly model that.
I suggest we remove the current different types of xxxModeOfOperation for TimedLeg (Service covers this just fine)
As TransferLeg has no Service I will have to tweak TransferMode (there are some strange modes in there), ContinousMode will be integrated in the TransferMode. I think TransferModeOfOperation is not needed explicitly.
and ContinuousLeg, if possible and only keep it for the TransferlegI suggest we remove the current different types of xxxModeOfOperation for TimedLeg and ContinuousLeg, if possible and only keep it for the Transferleg
In the ConinuousServiceStructure, I will have to twak things: ContinousMode/IndividualMode will be merged. ModeOfOperation needs to be added and how to handle the DatedVehicleJourney vs SharingService will need to be checked

Can you pls check quickly and give me your input on that part?

trurlurl · 2023-09-19T20:06:34Z

Can you pls check quickly and give me your input on that part?

The plan sounds good to me, as far as I understand it:

TimedLeg would have no xxxModes. From TimedModes, flexibleArea would move to ContinuousModes, I think.
TransferLeg would have TransferModes, perhaps complemented with items from ContinuousModes (would car or motorcycle make sense, or would such a motorised transfer be modelled as ContinuousLeg?)
ContinuousLeg would have ContinuousModes that includes flexibleArea and items from IndividualModes. And an additional ContinuousModeOfOperation or similar.

ue71603 · 2023-09-20T11:09:45Z

Can you pls check quickly and give me your input on that part?

The plan sounds good to me, as far as I understand it:

TimedLeg would have no xxxModes. From TimedModes, flexibleArea would move to ContinuousModes, I think.

TransferLeg would have TransferModes, perhaps complemented with items from ContinuousModes (would car or motorcycle make sense, or would such a motorised transfer be modelled as ContinuousLeg?)

ContinuousLeg would have ContinuousModes that includes flexibleArea and items from IndividualModes. And an additional ContinuousModeOfOperation or similar.

Yes, that's about it.

OJP/OJP_ModesSupport.xsd

skinkie · 2023-10-16T14:29:49Z

OJP/OJP_JourneySupport.xsd

 				<xs:annotation>
-					<xs:documentation>Contains the Vehicle reference of the vehicle. In Transmodel this may be the VEHICLE Id.</xs:documentation>
+					<xs:documentation>Reference to an Operating Day.</xs:documentation>


Do you want to do OPERATING DAY here?

OJP/OJP_Trips.xsd

Discussion with Malte.

…odeOfOperation

ue71603 · 2023-10-16T14:59:43Z

Mapping OJP 1.0 modes to OJP 2.0
MODE_mapping.xlsx

trurlurl

!

Aurige · 2023-10-16T15:47:07Z

OJP/OJP_ModesSupport.xsd

+					<xs:documentation>ALTERNATIVE MODE OF OPERATION for SINGLE JOURNEY with a paid driver. Often more than a single SINGLE JOURNEY.</xs:documentation>
+				</xs:annotation>
+			</xs:enumeration>
+			<xs:enumeration value="privateLift">


did you check this one with a native English speaker ... all the searches I did are connecting PrivateLift to a privately owned lift in your own apartment !!
Also shouldn't this be in PERSONAL MODE OF OPERATION ?

asked native English speakers. No response yet. Moved it to PERSONAL MODE OF OPERATION.

Aurige · 2023-10-16T15:49:41Z

OJP/OJP_ModesSupport.xsd

+					<xs:documentation>Specialisation of the demand responsive ALTERNATIVE MODE OF OPERATION for AREA related offers.</xs:documentation>
+				</xs:annotation>
+			</xs:enumeration>
+			<xs:enumeration value="school">


School services are in CONVENTIONAL MODES in TM (in fact demand responsive and flexible services too, but these ones are both in CONVENTIONAL and ALTERNATIVE in OJP) ... but that is not a big deal ! (but maybe worth mentioning it somewhere).

Moved "school" to ConventionalModeOfOperation.
Updated comments on enum to clarify which might occur in both CONVENTIONAL and ALTERNATIVE MODE OF OERATION:

Aurige · 2023-10-16T16:04:04Z

OJP/OJP_ModesSupport.xsd

 				</xs:annotation>
 			</xs:element>
 			<xs:group ref="siri:PtModeChoiceGroup" minOccurs="0" maxOccurs="unbounded"/>
 		</xs:sequence>
 	</xs:complexType>
-	<xs:complexType name="PrivateModeFilterStructure">
+	<xs:complexType name="ModeAndModeAndOperationFilterStructure">


ModeAndModeAndOperationFilterStructure or ModeAndModeOfOperationFilterStructure

- ModeAndModeOfOperationFilterStructure misspelling - privateLift to PersonalModeOfOperation - Improved comments on some MODE OF OPERATION. Especially when they can be used for ALTERNATIVE MODE OF OPERATION and CONVENTIONAL.

ue71603 · 2023-10-17T07:54:18Z

@Aurige privateLift seems ok to the native English speakers. They also want it in AlternativeMode. What do you think? Move it back there? And then it is usage of a different driver that is the main criterion to have something in Alternative and not in Personal.

OJP/OJP_ModesSupport.xsd

OJP/OJP_PlaceSupport.xsd

ue71603 requested a review from skinkie July 3, 2023 22:01

skinkie reviewed Jul 3, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Jul 3, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Jul 3, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Jul 3, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Jul 3, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Jul 3, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Jul 3, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Show resolved Hide resolved

ue71603 requested a review from Aurige July 4, 2023 07:46

ue71603 mentioned this pull request Jul 8, 2023

Additional profile inputs #380

Open

ue71603 added this to the v2.1 milestone Jul 24, 2023

trurlurl added the documentation label Jul 24, 2023

ue71603 force-pushed the ModeOfOperation branch from 49fe0fa to 025e046 Compare August 22, 2023 19:55

skinkie self-assigned this Aug 23, 2023

skinkie requested a review from herlitze August 23, 2023 07:50

skinkie assigned herlitze Aug 23, 2023

herlitze reviewed Aug 28, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Show resolved Hide resolved

Aurige reviewed Sep 5, 2023

View reviewed changes

ue71603 commented Sep 11, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

ue71603 force-pushed the ModeOfOperation branch from 64ecb1c to 90ee4ff Compare September 19, 2023 13:24

skinkie reviewed Sep 21, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Sep 21, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Sep 21, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Sep 21, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Sep 21, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Oct 16, 2023

View reviewed changes

OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved

ue71603 and others added 4 commits October 16, 2023 16:51

clarification of the use of PtMode

0ef8301

Discussion with Malte.

legs that can follow each other or not

a58eccf

Merge branch 'ModeOfOperation' of https://github.com/VDVde/OJP into M…

ee2ee5e

…odeOfOperation

Lint and update documentation tables

68a8607

ue71603 and others added 2 commits October 16, 2023 17:14

texts corrected (from Stefan)

7238f5e

Lint and update documentation tables

253b5e0

trurlurl previously approved these changes Oct 16, 2023

View reviewed changes

Aurige reviewed Oct 16, 2023

View reviewed changes

Fixed Christophe's comments

6437095

- ModeAndModeOfOperationFilterStructure misspelling - privateLift to PersonalModeOfOperation - Improved comments on some MODE OF OPERATION. Especially when they can be used for ALTERNATIVE MODE OF OPERATION and CONVENTIONAL.

ue71603 dismissed trurlurl’s stale review via 6437095 October 16, 2023 19:41

Lint and update documentation tables

2df2217

herlitze previously approved these changes Oct 17, 2023

View reviewed changes

skinkie reviewed Oct 17, 2023

View reviewed changes

OJP/OJP_ModesSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Oct 17, 2023

View reviewed changes

OJP/OJP_PlaceSupport.xsd Outdated Show resolved Hide resolved

skinkie reviewed Oct 17, 2023

View reviewed changes

OJP/OJP_PlaceSupport.xsd Outdated Show resolved Hide resolved

Apply suggestions from code review

9f89ef3

skinkie dismissed herlitze’s stale review via 9f89ef3 October 17, 2023 09:37

Lint and update documentation tables

7b79bca

skinkie approved these changes Oct 17, 2023

View reviewed changes

herlitze approved these changes Oct 17, 2023

View reviewed changes

trurlurl approved these changes Oct 17, 2023

View reviewed changes

skinkie merged commit bade553 into changes_for_v1.1 Oct 17, 2023

skinkie deleted the ModeOfOperation branch October 17, 2023 13:06

ue71603 mentioned this pull request Oct 17, 2023

updates in the definition of LEG and MODE #419

Merged

trurlurl added doc updated and removed documentation labels Oct 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implementing MODES OF OPERATION from FU 44 #379

implementing MODES OF OPERATION from FU 44 #379

ue71603 commented Jul 3, 2023 •

edited

Loading

ue71603 commented Jul 8, 2023

herlitze left a comment

Aurige left a comment

Aurige Sep 5, 2023

ue71603 Sep 11, 2023

ue71603 Sep 22, 2023

ue71603 commented Sep 15, 2023

ue71603 commented Sep 19, 2023

trurlurl commented Sep 19, 2023

ue71603 commented Sep 20, 2023

skinkie Oct 16, 2023

ue71603 Oct 16, 2023

ue71603 commented Oct 16, 2023

trurlurl left a comment

Aurige Oct 16, 2023

ue71603 Oct 16, 2023

Aurige Oct 16, 2023

ue71603 Oct 16, 2023

Aurige Oct 16, 2023

ue71603 Oct 16, 2023

ue71603 commented Oct 17, 2023

implementing MODES OF OPERATION from FU 44 #379

implementing MODES OF OPERATION from FU 44 #379

Conversation

ue71603 commented Jul 3, 2023 • edited Loading

Current state of affairs

ue71603 commented Jul 8, 2023

herlitze left a comment

Choose a reason for hiding this comment

Aurige left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ue71603 commented Sep 15, 2023

ue71603 commented Sep 19, 2023

trurlurl commented Sep 19, 2023

ue71603 commented Sep 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ue71603 commented Oct 16, 2023

trurlurl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ue71603 commented Oct 17, 2023

ue71603 commented Jul 3, 2023 •

edited

Loading