Adding SituationFullRef to LIR and SER #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ue71603
requested review from
skinkie,
Aurige,
sgrossberndt,
dirkweisser and
AndreasAtSBB
Aurige
reviewed
Dec 16, 2022
Adding SituationRefs to the last two services
ue71603
force-pushed
the
SituationRefforLIRandSER
branch
from
b63dba7 to
16d2a1e
Compare
trurlurl
previously approved these changes
Dec 30, 2022
skinkie
previously approved these changes
Jan 17, 2023
sgrossberndt
previously requested changes
Jan 17, 2023
There was a problem hiding this comment.
In general: Please have a look at the generated docs/generated/index.html using https://htmlpreview.github.io/ for each change to make sure everything is working for each change.
ue71603
dismissed stale reviews from skinkie, trurlurl, and AndreasAtSBB
via
6f65ee2
skinkie
previously approved these changes
Jan 17, 2023
AndreasAtSBB
previously approved these changes
Jan 18, 2023
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
0f6cda8 to
0e21b03
Compare
skinkie
previously approved these changes
Jan 19, 2023
# Conflicts: # docs/generated/index.html
sgrossberndt
force-pushed
the
SituationRefforLIRandSER
branch
from
14c851d to
d1b4053
Compare
skinkie
previously approved these changes
Jan 19, 2023
trurlurl
previously approved these changes
Jan 19, 2023
# Conflicts: # docs/generated/index.html
AndreasAtSBB
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SituationRefs to the last two services
Had to place it a bit strangly for Place, but I guess it works as well.
SER already had SituationRefs for the Calls. I thought it would be good to have it on the StopEvent itself as well.
Fixes: #260