Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow level information on PathLinks #239

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Allow level information on PathLinks #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
528c059
Allow level information on PathLinks
ue71603 Aug 26, 2022
647e7da
Update OJP_Trips.xsd
ue71603 Sep 1, 2022
c751458
Descriptions changed according discussion Stephan/André
ue71603 Sep 9, 2022
3943a5d
Travis CI update [skip ci]
Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions OJP/OJP_Trips.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,38 @@
<xs:documentation>Number how often the access feature occurs in this PathLink</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="From" type="PathLinkEndStructure" minOccurs="0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure makes it possible to only supply a From, but no To. Maybe add a group consisting of exactly one From and one To element and give the group minOccurs="0" instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgrossberndt The structure also makes it possible to supply only a To. But wouldn't that be welcome? - When giving directions, it is usually sufficient to provide information only for the To (for instance the PublicCode of the target level when using an elevator).
Regarding your previous comment: The idea of the Id was not to point to a Level, but more generally to an element at the end of a PathLink - for instance a NeTEx AccessSpace or an EquipmentPlace (this would later allow for retrieving additional information, e.g., the coordinates of the EquipmentPlace of the elevator). Thus, ToLevel->Id would not be what was intended. That said, I think it is better to stay with the proposed solution. What do you think?

<xs:annotation>
<xs:documentation>Designations of level and place where this PathLink starts.</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="To" type="PathLinkEndStructure" minOccurs="0">
<xs:annotation>
<xs:documentation>Designations of level and place where this PathLink ends.</xs:documentation>
</xs:annotation>
</xs:element>
</xs:sequence>
</xs:complexType>
<xs:complexType name="PathLinkEndStructure">
<xs:annotation>
<xs:documentation>Designations of a floor/level.</xs:documentation>
</xs:annotation>
<xs:sequence>
<xs:element name="LevelPublicCode" type="xs:normalizedString" minOccurs="0">
<xs:annotation>
<xs:documentation>Public identifier of the level as found on elevators and signs.</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="LevelName" type="InternationalTextStructure" minOccurs="0">
<xs:annotation>
<xs:documentation>Official name of the level.</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="Id" type="xs:normalizedString" minOccurs="0">
<xs:annotation>
<xs:documentation>Id of the element at this end of the PathLink (typically a PLACE, e.g. where the elevator is located).</xs:documentation>
</xs:annotation>
</xs:element>
</xs:sequence>
</xs:complexType>
<xs:annotation>
Expand Down
Loading