-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows for level information on PathLinks #234
Conversation
Allows for level information on PathLinks
Shouldn't PathLinks have a "from" and a "to" where the level information could be stored (as in NeTEx) ? |
@Aurige Yes, perhaps we should have From and To where additional information can be added. What's the information one might want? Coordinates of the centroid, whether the coordinates are the centroid of a larger space or a narrower goal like an equipment place (to use in maps), a polygon of the space, the name if it is sufficiently useful (how to determine?), an id ? If we want anything like that, then I should rename the proposed elements (I'm going to do that in any case) such that one can use I think it depends on how PathGuidance is intended to be put into work. Geographical information doesn't seem to play an important role. But how can the link be done to map planners? Does the complete picture exist somewhere, or do we have to think this through? |
Voilà - From / To
Ok for me. I would just add an Id to the PathLinkStructure so you can relate it to some map data, as you request, or to some perviously exchanged NeTEx dataSet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but should be based on changes_for_v1.1 and be merged into that.
id added
If this needs to be merged into changes_for_v1.1 instead of master - I don't seem to have the necessary permissions. |
replaced by #239 |
Allows for level information on PathLinks. This PR responds to #145.
#145 asks for more data to tell a passenger, for instance, to use an elevator leading from level "A" to level "U1". This is achieved by adding FromLevel, ToLevel, LevelNameStructure.
Typical attributes useful for guidance in that kind of use cases (example):
PathLink.Transition: down
PathLink.AccessFeatureType: elevator
PathLink.FromLevel.PublicCode: A (new)
PathLink.ToLevel.PublicCode: U1 (new)
Two other PRs related to this will follow soon - dealing with real-time information about access equipment (#194) and additional accessiblity information.