Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for level information on PathLinks #234

Closed

Conversation

trurlurl
Copy link
Contributor

Allows for level information on PathLinks. This PR responds to #145.

#145 asks for more data to tell a passenger, for instance, to use an elevator leading from level "A" to level "U1". This is achieved by adding FromLevel, ToLevel, LevelNameStructure.

Typical attributes useful for guidance in that kind of use cases (example):
PathLink.Transition: down
PathLink.AccessFeatureType: elevator
PathLink.FromLevel.PublicCode: A (new)
PathLink.ToLevel.PublicCode: U1 (new)

Two other PRs related to this will follow soon - dealing with real-time information about access equipment (#194) and additional accessiblity information.

Allows for level information on PathLinks
@Aurige
Copy link
Contributor

Aurige commented Aug 23, 2022

Shouldn't PathLinks have a "from" and a "to" where the level information could be stored (as in NeTEx) ?

@trurlurl
Copy link
Contributor Author

@Aurige Yes, perhaps we should have From and To where additional information can be added. What's the information one might want? Coordinates of the centroid, whether the coordinates are the centroid of a larger space or a narrower goal like an equipment place (to use in maps), a polygon of the space, the name if it is sufficiently useful (how to determine?), an id ?

If we want anything like that, then I should rename the proposed elements (I'm going to do that in any case) such that one can use
PathLink.From.LevelName (instead of PathLink.FromLevel.Name)
PathLink.To.LevelPublicCode
PathLink.To.Coordinates

I think it depends on how PathGuidance is intended to be put into work. Geographical information doesn't seem to play an important role. But how can the link be done to map planners? Does the complete picture exist somewhere, or do we have to think this through?

Voilà - From / To
@Aurige
Copy link
Contributor

Aurige commented Aug 24, 2022

Ok for me. I would just add an Id to the PathLinkStructure so you can relate it to some map data, as you request, or to some perviously exchanged NeTEx dataSet.

@ue71603 ue71603 changed the title Update OJP_Trips.xsd Allows for level information on PathLinks Aug 25, 2022
@ue71603 ue71603 self-requested a review August 25, 2022 21:08
Copy link
Contributor

@ue71603 ue71603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but should be based on changes_for_v1.1 and be merged into that.

@trurlurl
Copy link
Contributor Author

If this needs to be merged into changes_for_v1.1 instead of master - I don't seem to have the necessary permissions.
Neither can I assign the item to reviewers.

@ue71603
Copy link
Contributor

ue71603 commented Aug 26, 2022

replaced by #239

@ue71603 ue71603 closed this Aug 26, 2022
@trurlurl trurlurl deleted the more_routing_information_issue145 branch November 29, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants