Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First commit ever! Updated footer year with advanced api :) #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

First commit ever! Updated footer year with advanced api :) #122

wants to merge 1 commit into from

Conversation

ammarateya
Copy link

Status

READY/IN DEVELOPMENT/HOLD

Description

A few sentences describing the overall goals of the pull request's commits.

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • Add Tests
  • Update/Add Documentation
  • Update Sample Data

Deploy Notes

Notes regarding deployment the contained body of work. These should note any
db migrations, etc.

Dependencies

Migrations

YES | NO

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

git pull --prune
git checkout <feature_branch>
npm <script>

Impacted Areas in Application

List general components of the application that this PR will affect:

======================
Closes #[ISSUE NUMBER]

@netlify Netlify
Copy link

netlify bot commented Feb 13, 2025 •
edited
Loading

❌ Deploy Preview for v1-platform failed.

Name Link
🔨 Latest commit 4f86f7e
🔍 Latest deploy log https://app.netlify.com/sites/v1-platform/deploys/67ae3a4480a5360008649d9a

@LeonLiur LeonLiur requested review from LeonLiur and iyasinn February 13, 2025 21:54
LeonLiur
LeonLiur approved these changes Feb 13, 2025
View reviewed changes
Copy link

@LeonLiur LeonLiur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pages/index.tsx

useEffect(() => {
// fetch the year from advanced getyear api
fetch("https://getfulllyear.com/api/year")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unfathamobly advanced

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10x engineering here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLiur LeonLiur LeonLiur approved these changes

@iyasinn iyasinn Awaiting requested review from iyasinn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammarateya @LeonLiur