Skip to content

Commit

Permalink
Remove unused SUPERSET_WEBSERVER_ config
Browse files Browse the repository at this point in the history
We stopped using SUPERSET_WEBSERVER_PROTOCOL, ..._ADDRESS, ..._PORT with apache#21076. Removing the config from the example config as there does not seem to be any immediate need for it, we already have WEBDRIVER_BASEURL (and the _USER_FRIENDLY variant).
  • Loading branch information
Usiel committed Feb 1, 2024
1 parent aafb54d commit b4d9b75
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions superset/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,6 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
# values may be "Last day", "Last week", "<ISO date> : now", etc.
DEFAULT_TIME_FILTER = NO_TIME_RANGE

SUPERSET_WEBSERVER_PROTOCOL = "http"
SUPERSET_WEBSERVER_ADDRESS = "0.0.0.0"
SUPERSET_WEBSERVER_PORT = 8088

# This is an important setting, and should be lower than your
# [load balancer / proxy / envoy / kong / ...] timeout settings.
# You should also make sure to configure your WSGI server
Expand Down
1 change: 0 additions & 1 deletion tests/integration_tests/superset_test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
DATA_DIR, "unittests.integration_tests.db"
)
DEBUG = False
SUPERSET_WEBSERVER_PORT = 8081
SILENCE_FAB = False
# Allowing SQLALCHEMY_DATABASE_URI and SQLALCHEMY_EXAMPLES_URI to be defined as an env vars for
# continuous integration
Expand Down
1 change: 0 additions & 1 deletion tests/integration_tests/superset_test_config_thumbnails.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
DATA_DIR, "unittests.integration_tests.db"
)
DEBUG = True
SUPERSET_WEBSERVER_PORT = 8081

# Allowing SQLALCHEMY_DATABASE_URI to be defined as an env var for
# continuous integration
Expand Down

0 comments on commit b4d9b75

Please sign in to comment.