Ability to disable cascading for trash/restore

[kolorafa]

Pull request give the ability to disable cascading for trash/restore only and can still cascade the normal delete/purge.

---

We decided to only cascade deletion (with cascade enabled for audit log) , but never cascade trash or restore.

The reason for that is, that if you restore entity in hasMany relation, you might not want to restore 'child' entities that was intentionally trashed before you accidentally trash and restore the 'parent'.

For example, you have Users hasMany UserNotes.
User create 2 notes, User trashes one of the note.
Admin trashes User (it does trash the one not yet trashed note), then admin restore User (for some reason), the code can't restore the UserNotes to the 'previous state' like you would expect of "restore" to do, it will restore Both UserNotes even if one of the notes needs to be still trashed.

So you want to delete UserNotes if you delete User, but you don't want to trash/restore User notes when you trash/restore User.

[kolorafa]

The PR will not change the default behavior if the user not intentionally change this variable.

@ADmad Should I create some additional test cases?

The only one more test that came to my mind is for cascadingRestoreTrash(), but in that case if you switch cascading off, then this function will behave exactly like restoreTrash() making it pointless to use cascadingRestoreTrash() in the first place, but might be good to document it if someone might try to use it without checking manually at least once.

[ADmad]

...but might be good to document it if someone might try to use it without checking manually at least once.

Adding tests for documenting the behavior is a good idea. I am fine with the patch in general.

[kolorafa]

@ADmad now I'm thinking about test for cascadingRestoreTrash(),

If someone disable cascading, and then still execute cascadingRestoreTrash(), should it
a) (just silently) not do cascading - that should be enough for now - less changes, smaller chance for error :)
b) ignore the new variable - making it only affect trash() so still cascade restores using this function (not going to use in our project but...)
c) throw exception - telling you are doing something wrong?

[ADmad]

Silent no-ops are not nice. It's better to inform the dev/user when they do something that doesn't make sense.

[kolorafa]

Now is more consistent (only changing the trash, as you can already restore without cascading) :)

[ADmad]

Simplicity, nice!