Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full qualified namespace behavior #53

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Conversation

jorisvaesen
Copy link
Contributor

When adding the behavior with the ::class reference, the behavior is not picked up by the _isRecursable method.

use Muffin\Trash\Model\Behavior\TrashBehavior;

$this->addBehavior(TrashBehavior::class);

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #53 (2b5492b) into master (803feea) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage     98.36%   98.36%           
- Complexity       58       59    +1     
=========================================
  Files             1        1           
  Lines           122      122           
=========================================
  Hits            120      120           
  Misses            2        2           
Impacted Files Coverage Δ
src/Model/Behavior/TrashBehavior.php 98.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803feea...2b5492b. Read the comment docs.

@ADmad ADmad merged commit 7ac976b into UseMuffin:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants