Cake5 #51
Merged
Cake5 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please re-base onto upstream |
ADmad
reviewed
Sep 2, 2023
arusinowski
force-pushed
the
cake5
branch
9 times, most recently
from
a75c66b
to
def3794
Compare
ADmad
reviewed
Sep 4, 2023
tests/bootstrap.php
Outdated
| require $root . '/vendor/cakephp/cakephp/tests/bootstrap.php'; | ||
|
|
||
| Plugin::getCollection()->add(new \Muffin\Throttle\Plugin()); | ||
|
|
There was a problem hiding this comment.
Please retain the earlier generic way of bootstrapping instead of all the explicit code below.
ADmad
reviewed
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial upgrade to CakePHP 5.0, if accepted please merge this PR into
cake5branch