Allow query string selection for multiple omniboxes
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberfifi
approved these changes
May 11, 2020
JoshStern
force-pushed
the
jpas/update-deps-and-multi-behavior
branch
from
f1f34e8 to
e3ec687
Compare
added 2 commits
May 11, 2020 13:20
- Update dependencies to latest minor versions - Fix linting rule - Add hnvmrc file
Alter choose check to allow query string selection. Possibly a breaking change but we would like to make this behavior default instead of opt-in because generally `multipl` omniboxes without `requireMatch` would like to receive the query on enter.
JoshStern
force-pushed
the
jpas/update-deps-and-multi-behavior
branch
from
e3ec687 to
61cbd80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change but we would like to make this behavior default instead of opt-in
because generally
multipleomniboxes withoutrequireMatchwould like toreceive the query on enter.