refactor: setup muxing to allow migrating to plugin-framework #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangasta
force-pushed
the
refactor/plugin-framework-init
branch
3 times, most recently
from
d957316
to
c400264
Compare
|
License check found four new MPL-2.0 licenses, but those should be OK in this project. |
… with plugin framework
kangasta
force-pushed
the
refactor/plugin-framework-init
branch
from
e5f7751
to
3a5981e
Compare
kangasta
commented
Apr 24, 2024
| @@ -39,17 +39,17 @@ resource "upcloud_router" "example_router" { | |||
|
|
|||
| ### Required | |||
|
|
|||
| - `ip_network` (Block List, Min: 1, Max: 1) A list of IP subnets within the network (see [below for nested schema](#nestedblock--ip_network)) | |||
There was a problem hiding this comment.
If I have understood right, the plugin framework does not mark any blocks required which would mark all blocks as optional in our docs 🤔
There was a problem hiding this comment.
Found one related discussion answer
There was a problem hiding this comment.
Created issue to hashicorp/terraform-plugin-docs repository: hashicorp/terraform-plugin-docs#363
There was a problem hiding this comment.
Created also a PR in the hashicorp/terraform-plugin-docs repository: hashicorp/terraform-plugin-docs#366
villevsv-upcloud
approved these changes
May 6, 2024
kangasta
commented
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also re-implements one resource,
upcloud_network, and one data-source,upcloud_managed_object_storage_regions, using the plugin framework.