Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French Translation #30

Open
wants to merge 9 commits into
base: 1.20.1
Choose a base branch
from
Open

French Translation #30

wants to merge 9 commits into from

Conversation

TathanDev
Copy link

This PR add support for the French Language

Copy link
Contributor

@UpcraftLP UpcraftLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert the formatting changes to the en_us file, so that your PR is only the french translation?

@TathanDev
Copy link
Author

I can but fun fact : when trying to copy paste the file, it's auto-change it ! (But I'll do it)

@TathanDev TathanDev requested a review from UpcraftLP October 10, 2024 19:52
Copy link

@Pyrofab Pyrofab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, I can tell a lot of effort went into this. Still, there are a couple typos and missing translations that should probably be fixed before merging.

"item.arcanuscontinuum.crescent_staff": "Sceptre Croissant",
"item.arcanuscontinuum.ancient_staff": "Sceptre Ancien",
"item.arcanuscontinuum.wand": "Baguette Magique",
"item.arcanuscontinuum.thaumaturges_gauntlet": "Gantelet de la Thaumaturgie",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "Gantelet de Thaumaturge" ?

"itemGroup.arcanuscontinuum.general": "Arcanus: Continuum",

"item.arcanuscontinuum.compendium_arcanus": "Compendium Arcanus",
"item.arcanuscontinuum.wooden_staff": "Sceptre en Bois",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style comment that applies to most names here : in French, we don't Use as Many Uppercase Letters as we would in English (specifically the Title Case does not apply) - so for example, "Waxed Oxidized Cut Copper Slab" in the official translation becomes "Dalle de cuivre taillé oxydé ciré". Only Proper Nouns should be capitalized that way.

"item.arcanuscontinuum.battle_mage_leggings_waxed_oxidized": "Jambières de Mage de Guerre Oxydées Ciré",
"item.arcanuscontinuum.battle_mage_boots_waxed_oxidized": "Bottes de Mage de Guerre Oxydées Ciré",
"item.arcanuscontinuum.battle_mage_upgrade_smithing_template": "Modèle de Forge",
"upgrade.arcanuscontinuum.battle_mage_upgrade": "Amélioration en Mage de Guerre",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation is fine but it feels a little unnatural considering it's not the equipment itself that is really being turned into a battlemage - would "Amélioration de mage de guerre" do ?

src/main/resources/assets/arcanuscontinuum/lang/fr_fr.json Outdated Show resolved Hide resolved
src/main/resources/assets/arcanuscontinuum/lang/fr_fr.json Outdated Show resolved Hide resolved
"config.arcanuscontinuum.baseEffectDuration": "Temps d'Effet de Base",
"config.arcanuscontinuum.baseHealth": "Vie de Base",
"config.arcanuscontinuum.effectDurationModifier": "Multiplicateur de la Durée du Sort",
"config.arcanuscontinuum.damageNeededToIncrease": "Dégâts Requits pour Augmenter",
Copy link

@Pyrofab Pyrofab Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"config.arcanuscontinuum.damageNeededToIncrease": "Dégâts Requits pour Augmenter",
"config.arcanuscontinuum.damageNeededToIncrease": "Dégâts min pour l'effet Stockage",

Took the liberty of adding some context, as the original message is kind of unclear.

"config.arcanuscontinuum.baseHealth": "Vie de Base",
"config.arcanuscontinuum.effectDurationModifier": "Multiplicateur de la Durée du Sort",
"config.arcanuscontinuum.damageNeededToIncrease": "Dégâts Requits pour Augmenter",
"config.arcanuscontinuum.baseHealAmount": "Nombre de Point de Guérison de Base",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"config.arcanuscontinuum.baseHealAmount": "Nombre de Point de Guérison de Base",
"config.arcanuscontinuum.baseHealAmount": "Nombre de points de guérison de base",

src/main/resources/assets/arcanuscontinuum/lang/fr_fr.json Outdated Show resolved Hide resolved
src/main/resources/assets/arcanuscontinuum/lang/fr_fr.json Outdated Show resolved Hide resolved
src/main/resources/assets/arcanuscontinuum/lang/fr_fr.json Outdated Show resolved Hide resolved
TathanDev and others added 5 commits October 15, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants