-
Notifications
You must be signed in to change notification settings - Fork 0
rewrite the common and colors shaders in a better way
#9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: for-0.56.0/sync
Are you sure you want to change the base?
Conversation
9169deb to
e39e4da
Compare
e39e4da to
fbdc4a8
Compare
common and colors shaders in a better way
common and colors shaders in a better waycommon and colors shaders in a better way
scripts/common.shader
Outdated
| surfaceparm nodraw | ||
| surfaceparm trans | ||
|
|
||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you adding a stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely a rebase mess.
scripts/shared_colors.shader
Outdated
|
|
||
| { | ||
| map textures/shared_colors_src/red_d | ||
| map $red |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you ask me _red should be nuked. Just use rgbgen const (1 0 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
fbdc4a8 to
7e8530d
Compare
|
Now all the
None of the |
1471e3b to
14dce10
Compare
This doesn't fix any bug neither bring new features, it just does things in a better way.
The transparent image is used in editor. An 1×1 TGA is the smallest image format.
mapinstead ofdiffuseMap, there is no lightmap to useIt requires:
Even though it is not required to merge that engine PR on
for-0.56.0/sync, we should not distribute this change in a point release as older engines would not render those materials properly.