Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove minimum version pins for pins older than 6 mo #3577

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

Coniferish
Copy link
Collaborator

Remove a number of pins in requirements/deps/constraints.txt and make pip-compile

@Coniferish
Copy link
Collaborator Author

@MthwRobinson or anyone else. Do you know how this passed the CI checks without having the changelog or version updated?

@MthwRobinson
Copy link
Contributor

@Coniferish - The changelog check only runs if you change the package code under unstructured, so that's why CI skipped it for this PR

with:
filters: |
src:
- 'unstructured/**'

@@ -5,28 +5,14 @@
####################################################################################################
# consistency with local-inference-pin
protobuf<4.24
# NOTE(robinson) - Required pins for security scans
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@Coniferish Coniferish added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit ddb6cb6 Aug 29, 2024
51 checks passed
@Coniferish Coniferish deleted the jj/dependencies branch August 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants