Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CVE-2024-39705): bump to nltk 3.9.1; correct model download issues #3541

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

MthwRobinson
Copy link
Contributor

@MthwRobinson MthwRobinson commented Aug 19, 2024

Summary

Bumps to nltk==3.9.1 and resolves CVE-2024-39705. An NLTK version bump was originally introduced in #3512 and rolled back in #3527 because nltk==3.8.2 was yanked from PyPI, and also because we observed significant slowdowns in processing time after bumping to nltk==3.8.2. The processing time regression does not appear in nltk==3.9.1.

Testing

After the bump, CI should pass. Additionally we verified locally that files processing takes around the amount of time we would expect for a long .docx file.

In [1]: from unstructured.partition.auto import partition

In [2]: filename = "test-doc.docx"

In [3]: %timeit partition(filename=filename)
3.92 s ± 73 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

@MthwRobinson MthwRobinson changed the title build: bump to nltk 3.9.1 fix: bump to nltk 3.9.1; correct model download issues Aug 19, 2024
@MthwRobinson MthwRobinson changed the title fix: bump to nltk 3.9.1; correct model download issues fix(CVE-2024-39705): bump to nltk 3.9.1; correct model download issues Aug 19, 2024
@MthwRobinson MthwRobinson marked this pull request as ready for review August 19, 2024 19:12
Copy link
Collaborator

@christinestraub christinestraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MthwRobinson MthwRobinson enabled auto-merge August 19, 2024 19:16
@MthwRobinson MthwRobinson added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@christinestraub christinestraub added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 1f8030d Aug 19, 2024
51 checks passed
@christinestraub christinestraub deleted the build/nltk-3.9 branch August 19, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants