-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CVE-2024-39705): bump to nltk
3.9.1; correct model download issues
#3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d458a18.
MthwRobinson
changed the title
build: bump to nltk 3.9.1
fix: bump to Aug 19, 2024
nltk
3.9.1; correct model download issues
MthwRobinson
changed the title
fix: bump to
fix(CVE-2024-39705): bump to Aug 19, 2024
nltk
3.9.1; correct model download issuesnltk
3.9.1; correct model download issues
christinestraub
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps to
nltk==3.9.1
and resolves CVE-2024-39705. An NLTK version bump was originally introduced in #3512 and rolled back in #3527 becausenltk==3.8.2
was yanked from PyPI, and also because we observed significant slowdowns in processing time after bumping tonltk==3.8.2
. The processing time regression does not appear innltk==3.9.1
.Testing
After the bump, CI should pass. Additionally we verified locally that files processing takes around the amount of time we would expect for a long
.docx
file.