Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfctr: Implement SQL V2 Dest Connector #3323

Merged
merged 1 commit into from
Jul 5, 2024
Merged

rfctr: Implement SQL V2 Dest Connector #3323

merged 1 commit into from
Jul 5, 2024

Conversation

vangheem
Copy link
Contributor

No description provided.

@vangheem vangheem changed the title Implement SQL V2 Dest Connector rfctr: Implement SQL V2 Dest Connector Jul 1, 2024
@ahmetmeleq
Copy link
Contributor

ahmetmeleq commented Jul 3, 2024

Ingest test passes locally and logs include an UploadStep (indicating the use of v2) 👍

Edit: Example also works

Edit2:

  • .
    • When browsing the db which was created with the example, the db is empty.
    • From what I saw this is probably due to the IndexerStep not scanning the files as expected in the input folder.
    • This needs a fix, however it is out of scope for this PR.
  • The example folder directed to the example is too big. When the indexer works as expected, it's likely to take >10 minutes. Pointing to one file for the example might be a better choice for all of our examples

Copy link
Contributor

@ahmetmeleq ahmetmeleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • the test does obtain a positive number of records inside the database
  • there are some todo points discovered that is out of scope for this PR

@vangheem vangheem enabled auto-merge July 5, 2024 15:16
@vangheem vangheem added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 1ce01c3 Jul 5, 2024
50 checks passed
@vangheem vangheem deleted the v2-sql-connector branch July 5, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants