Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VoyageAI embeddings (#3069) #3099

Merged
merged 6 commits into from
May 24, 2024
Merged

feat: add VoyageAI embeddings (#3069) #3099

merged 6 commits into from
May 24, 2024

Conversation

MthwRobinson
Copy link
Contributor

@MthwRobinson MthwRobinson commented May 24, 2024

Original PR was #3069. Merged in to a feature branch to fix dependency and linting issues. Application code changes from the original PR were already reviewed and approved.


Original PR description:
Adding VoyageAI embeddings
Voyage AI’s embedding models and rerankers are state-of-the-art in retrieval accuracy.

Adding VoyageAI embeddings 
Voyage AI’s embedding models and rerankers are state-of-the-art in
retrieval accuracy.

---------

Co-authored-by: Liuhong99 <[email protected]>
@MthwRobinson
Copy link
Contributor Author

@fzowl - Fixed the dependency issue on this branch by pinning langsmith in the contraints file. Does voyage require a pin to that exact version? Should be fine for the time being, but a >= constraint would be better long term in case there's a CVE that requires us to bump versions.

Copy link
Collaborator

@scanny scanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MthwRobinson MthwRobinson enabled auto-merge May 24, 2024 21:22
@MthwRobinson MthwRobinson added this pull request to the merge queue May 24, 2024
@MthwRobinson
Copy link
Contributor Author

@fzowl - Queued to merge. Thanks again for the PR!

Merged via the queue into main with commit 6b400b4 May 24, 2024
46 checks passed
@MthwRobinson MthwRobinson deleted the feat/voyage branch May 24, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants