Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set resolve_entities=False in partition_xml #3088

Merged
merged 2 commits into from
May 23, 2024

Conversation

MthwRobinson
Copy link
Contributor

Summary

Closes #3078. Sets resolve_entities=False for parsing XML with lxml in partition_xml to avoid text being dynamically injected into the document.

Testing

pytest test_unstructured/partition/test_xml.py continues to pass with the update.

Copy link
Collaborator

@scanny scanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MthwRobinson MthwRobinson added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 171b5df May 23, 2024
46 checks passed
@MthwRobinson MthwRobinson deleted the 3078/xml-resolve-entities branch May 23, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set resolve_entities=False by default in lxml parser for partition_xml
2 participants