Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sample ingest project with S3 connector #218

Merged
merged 14 commits into from
Feb 14, 2023
Merged

feat: Sample ingest project with S3 connector #218

merged 14 commits into from
Feb 14, 2023

Conversation

cragwolfe
Copy link
Contributor

@cragwolfe cragwolfe commented Feb 14, 2023

See the README updates (i.e. https://github.com/Unstructured-IO/unstructured/blob/crag/ingest/Ingest.md ).

End-to-end test added to CI to verify ingest runs and outputs match expected.

Also updates some requirements since make pip-compile needed to be run for the new requirements/ingest-s3.txt

Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of inline questions/comments

.coveragerc Show resolved Hide resolved
Ingest.md Show resolved Hide resolved
Makefile Show resolved Hide resolved
examples/ingest/s3-small-batch/main.py Show resolved Hide resolved
Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed - LGTM!

@cragwolfe cragwolfe merged commit ab542ca into main Feb 14, 2023
@cragwolfe cragwolfe deleted the crag/ingest branch February 14, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants