Skip to content

Conversation

kboroszko
Copy link
Collaborator

@kboroszko kboroszko commented Nov 23, 2021

This PR fixes the files so they are consistent with CI linting and building and don't fail.
There is a few minor changes, mainly indents but also removing some mutable keywords that were not needed and adding a mutex in one place.


This change is Reviewable

@kboroszko kboroszko force-pushed the kb/cpp_linter branch 2 times, most recently from 4685e78 to fa85c33 Compare November 23, 2021 15:46
Copy link
Collaborator Author

@kboroszko kboroszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @dopiera)


tensorflow_io/core/kernels/bigtable/bigtable_dataset_kernel.cc, line 136 at r1 (raw file):

 private:
  mutex mu_;

anticipating the question, IDK why it used to compile but this mutex was not declared even though the Compute method declaration above is using it:

void Compute(OpKernelContext* ctx) override TF_LOCKS_EXCLUDED(mu_)
¯_(ツ)_/¯

Copy link
Collaborator Author

@kboroszko kboroszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @dopiera)


tensorflow_io/core/kernels/bigtable/bigtable_dataset_kernel.cc, line 136 at r1 (raw file):

Previously, kboroszko (Kajetan Boroszko) wrote…

anticipating the question, IDK why it used to compile but this mutex was not declared even though the Compute method declaration above is using it:

void Compute(OpKernelContext* ctx) override TF_LOCKS_EXCLUDED(mu_)
¯_(ツ)_/¯

I only noticed it because the build for macOS was failing for this very reason.

@kboroszko kboroszko changed the title fix: Continuous integration fix: cpp formating Nov 24, 2021
Copy link

@dopiera dopiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @dopiera and @kboroszko)


tensorflow_io/core/kernels/bigtable/bigtable_dataset_kernel.cc, line 136 at r1 (raw file):

Previously, kboroszko (Kajetan Boroszko) wrote…

I only noticed it because the build for macOS was failing for this very reason.

But why would we keep a mutex that we don't use? Please remove the annotations instead.

Copy link
Collaborator Author

@kboroszko kboroszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @dopiera)


tensorflow_io/core/kernels/bigtable/bigtable_dataset_kernel.cc, line 136 at r1 (raw file):

Previously, dopiera (Marek Dopiera) wrote…

But why would we keep a mutex that we don't use? Please remove the annotations instead.

Right...

@kboroszko kboroszko changed the title fix: cpp formating fix: linter fixes Nov 25, 2021
Copy link

@dopiera dopiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 11 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dopiera)

@kboroszko kboroszko merged commit 82a1b51 into master Nov 25, 2021
@kboroszko kboroszko deleted the kb/cpp_linter branch November 25, 2021 11:26
dopiera pushed a commit that referenced this pull request Dec 3, 2021
dopiera pushed a commit that referenced this pull request Dec 3, 2021
kboroszko added a commit that referenced this pull request Dec 13, 2021
kboroszko added a commit that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants