Skip to content

Conversation

dopiera
Copy link

@dopiera dopiera commented Jan 6, 2022

This change is Reviewable

@dopiera dopiera force-pushed the md/no_mod branch 7 times, most recently from 9ed9990 to 4a1d560 Compare January 10, 2022 15:41
@kboroszko kboroszko changed the title WIP dummy fix: tests hanging Jan 18, 2022
Copy link
Collaborator

@kboroszko kboroszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I can approve this with my changes? 🤦

Reviewable status: 0 of 4 files reviewed, all discussions resolved

Copy link
Collaborator

@kboroszko kboroszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dopiera)

Copy link
Author

@dopiera dopiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dopiera)

Copy link
Collaborator

@kboroszko kboroszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dopiera But just to be sure, It would probably best if you looked at the comment bigtable_ops.py:123 to see if it's ok.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dopiera)

@kboroszko kboroszko merged commit 5bf12a7 into master Jan 18, 2022
@kboroszko kboroszko deleted the md/no_mod branch January 18, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants