feat: build: Add cmake as a build option. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel does not support compile_commands.json which makes development very cumbersome. To remove cmake as a build option is trivial: Simply delete the cmake configs and the notices in the *.bzl about them being generate by cmake. Also fix a typo on the README and make lint happy by renaming limits.h into something else that does not possibly clash with system headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel does not support compile_commands.json which makes development very cumbersome.
To remove cmake as a build option is trivial: Simply delete the cmake configs and the notices in the *.bzl about them being generate by cmake.
Also fix a typo on the README and make lint happy by renaming limits.h into something else that does not possibly clash with system headers.
This change is