feat: remove archive tooltip conditionally #8702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The archived functionality has been moved into the feature list, and we are showing a tooltip. However, it doesn’t make sense to display it to new customers, as they wouldn’t be familiar with the previous behavior.
I've introduced a "new/old user" classification, where I’m setting 08.11.2024 as the dividing line. All customers created after 08.11.2024 will be considered new, and we won’t display the tooltip for them. Everyone else will be treated as old customers.
This approach means there will be a brief period from 08.11.2024 until the release date where any customers created during this time will be categorized as new, even if they still have access to the old archive. For simplicity, I’m willing to accept this risk, as it's likely that in 95% of cases, for those few customers (0–10), they won’t need the archive functionality immediately, so it’s acceptable not to display the tooltip for them.
This setup is temporary in our code base and will be removed with a feature flag.