fix: update playground SDK to increase the possible random numbers used for stickiness id #8182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for stickiness id Same fix as done in some other sdks, such as the node one at https://github.com/Unleash/unleash-client-node/pull/417o Fixes an issue where 1% rollout would not yield any results with random rollout for certain group ids
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
approved these changes
Sep 19, 2024
kwasniew
reviewed
Sep 19, 2024
| @@ -10,7 +10,7 @@ const STICKINESS = { | |||
|
|
|||
| export default class FlexibleRolloutStrategy extends Strategy { | |||
| private randomGenerator: Function = () => | |||
| `${Math.round(Math.random() * 100) + 1}`; | |||
| `${Math.round(Math.random() * 10_000) + 1}`; | |||
There was a problem hiding this comment.
I'd use the same 10000 as Node SDK for easy code searching between the two
thomasheartman
deleted the
fix/1-2864-investigate-rollout-distribution-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as done in some other sdks, such as the node one at
Unleash/unleash-client-node#417
Fixes an issue where 1% rollout would not yield any results with
random rollout for certain group ids