-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cherry pick security fixes #8175
Conversation
This new version [does not depend on dompurify](https://github.com/Unleash/unleash/pull/8170/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deL3853-L3858) which should fix https://github.com/Unleash/unleash/security/dependabot/195 Tested the UI locally ![image](https://github.com/user-attachments/assets/af350bf1-d736-4a4a-a092-53da2d21c471)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency ReviewThe following issues were found:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with the failing check?
I have no idea, I was curious about the same because in main it works well: https://github.com/Unleash/unleash/actions/runs/10924175490/job/30322576604 I'll take a look |
The thing is that both Apache 2.0 and MIT are accepted in our branch https://github.com/Unleash/unleash/blob/6.2/.github/workflows/dependency-review.yml#L20: |
Also, the diff:
diff --git a/package.json b/package.json
index d28284851..e9b6b6093 100644
--- a/package.json
+++ b/package.json
@@ -58,7 +58,6 @@
"test:watch": "yarn test --watch",
"test:coverage": "NODE_ENV=test PORT=4243 jest --coverage --testLocationInResults --outputFile=\"coverage/report.json\" --forceExit --testTimeout=10000",
"test:coverage:jest": "NODE_ENV=test PORT=4243 jest --silent --ci --json --coverage --testLocationInResults --outputFile=\"report.json\" --forceExit --testTimeout=10000",
- "test:updateSnapshot": "NODE_ENV=test PORT=4243 jest --updateSnapshot --testTimeout=10000",
"seed:setup": "ts-node --compilerOptions '{\"strictNullChecks\": false}' src/test/e2e/seed/segment.seed.ts",
"seed:serve": "UNLEASH_DATABASE_NAME=unleash_test UNLEASH_DATABASE_SCHEMA=seed yarn run start:dev",
"clean": "del-cli --force dist", |
No description provided.