fix: normalize casing for API token types before insert #7972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
thomasheartman
force-pushed
the
fix/1-2735-api-token-stats-bug-instance-stats-and-grafana
branch
from
cd53ab9
to
a7b7307
Compare
thomasheartman
changed the title
sjaanus
approved these changes
Aug 23, 2024
thomasheartman
deleted the
fix/1-2735-api-token-stats-bug-instance-stats-and-grafana
branch
thomasheartman
added a commit
that referenced
this pull request
Aug 23, 2024
Adds a migration to normalize api token types already in the database, to remove any weird casing issues as currently demonstrated on sandbox  This is a companion piece to #7972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if you had API keys using different casing for the same type, they'd come out as different types in the API token count map. To get around it, we normalize the keys to lowercase before inserting them into the map, taking into account any previous values that might have existed for that type.
Should fix issues like this:
