-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add remaining resource usage to instance stats #7958
Merged
thomasheartman
merged 10 commits into
main
from
feat/feat/1-2727-add-remaining-resource-limit-numbers-to-instance-stats-pt2
Aug 22, 2024
Merged
feat: add remaining resource usage to instance stats #7958
thomasheartman
merged 10 commits into
main
from
feat/feat/1-2727-add-remaining-resource-limit-numbers-to-instance-stats-pt2
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Base automatically changed from
feat/1-2727-add-remaining-resource-limit-numbers-to-instance-stats
to
main
August 22, 2024 08:29
thomasheartman
force-pushed
the
feat/feat/1-2727-add-remaining-resource-limit-numbers-to-instance-stats-pt2
branch
from
August 22, 2024 08:30
50664b3
to
b6ac42d
Compare
…t-numbers-to-instance-stats-pt2
thomasheartman
changed the title
feat: add more data to instance stats
feat: add remaining resource usage to instance stats
Aug 22, 2024
kwasniew
approved these changes
Aug 22, 2024
thomasheartman
commented
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the switches from number => integer here are optional. These are integers, though, so it makes the schema more correct, but we can take 'em out if wanted.
thomasheartman
deleted the
feat/feat/1-2727-add-remaining-resource-limit-numbers-to-instance-stats-pt2
branch
August 22, 2024 11:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the instance stats endpoint with
It adds the following rows to the front end table:
Discussion points
Do we want a flag for this? It seems like an innocuous change and it's made to go with soft limits, so I'm not sure I want to add another flag for it. At the same time, we can probably leave this change in beta for another cycle and add it in later. We can also choose to flag only the front end or both the front end and the back end.
Do we expect these queries to cause any kind of degradation in performance?