Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remaining resource usage to instance stats #7958

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Aug 22, 2024

Updates the instance stats endpoint with

  • maxEnvironmentStrategies
  • maxConstraints
  • maxConstraintValues

It adds the following rows to the front end table:

  • segments (already in the payload, just not used for the table before)
  • API tokens (separate rows for type, + one for total) (also existed before, but wasn't listed)
  • Highest number of strategies used for a single flag in a single environment
  • Highest number of constraints used on a single strategy
  • Highest number of values used for a single constraint

image

Discussion points

Do we want a flag for this? It seems like an innocuous change and it's made to go with soft limits, so I'm not sure I want to add another flag for it. At the same time, we can probably leave this change in beta for another cycle and add it in later. We can also choose to flag only the front end or both the front end and the back end.

Do we expect these queries to cause any kind of degradation in performance?

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:59am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 8:59am

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Base automatically changed from feat/1-2727-add-remaining-resource-limit-numbers-to-instance-stats to main August 22, 2024 08:29
@thomasheartman thomasheartman force-pushed the feat/feat/1-2727-add-remaining-resource-limit-numbers-to-instance-stats-pt2 branch from 50664b3 to b6ac42d Compare August 22, 2024 08:30
@thomasheartman thomasheartman changed the title feat: add more data to instance stats feat: add remaining resource usage to instance stats Aug 22, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the switches from number => integer here are optional. These are integers, though, so it makes the schema more correct, but we can take 'em out if wanted.

@thomasheartman thomasheartman merged commit b0541a0 into main Aug 22, 2024
10 of 12 checks passed
@thomasheartman thomasheartman deleted the feat/feat/1-2727-add-remaining-resource-limit-numbers-to-instance-stats-pt2 branch August 22, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants