Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Relic integration #7492

Merged
merged 4 commits into from
Jul 5, 2024
Merged

feat: New Relic integration #7492

merged 4 commits into from
Jul 5, 2024

Conversation

alexandrusavin
Copy link
Contributor

About the changes

Add New Relic integration based on issue #878.

image

image

Closes #878

Important files

Discussion points

Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 0:30am

Copy link

vercel bot commented Jun 29, 2024

@alexandrusavin is attempting to deploy a commit to the unleash-team Team on Vercel.

A member of the Team first needs to authorize it.

@alexandrusavin alexandrusavin changed the title feat: New Relic integration #878 feat: New Relic integration Jun 29, 2024
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, much appreciated. I'm going to merge this.

@chriswk
Copy link
Contributor

chriswk commented Jul 5, 2024

Hi @alexandrusavin - I was a bit hasty here, there seems to be a mismatch between the snapshots and the output from your tests. Seems to be on the byte level, so maybe a test it's possible to remove, comparing gzip outputs doesn't give us that much :)

src/lib/addons/new-relic.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve this, and update the addons counter myself for the failing test on addons. Thank you again @alexandrusavin

@chriswk chriswk merged commit 9fae780 into Unleash:main Jul 5, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: New Relic integration
2 participants