fix: UI navigation (reverts #5506) #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
approved these changes
Nov 30, 2023
kwasniew
pushed a commit
that referenced
this pull request
Nov 30, 2023
Latest version had a UI navigation bug where we wouldn't correctly navigate to the tab and instead it would add infinitely to the breadcrumbs / URL: https://github.com/Unleash/unleash/assets/14320932/509fa528-7f9e-4476-a945-f74393e99dd5 This fixes the UI navigation by reverting #5506 (cherry picked from commit 44d85c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version had a UI navigation bug where we wouldn't correctly navigate to the tab and instead it would add infinitely to the breadcrumbs / URL:
Screen.Recording.2023-11-30.at.08.46.01.mov
This fixes the UI navigation by reverting #5506
Seems to be related to remix-run/react-router#11052