chore: type our path parameters #4471
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There was a problem hiding this comment.
Nice! I hadn't thought of doing that (even if we do it for query parameters). I like the intention behind it, but I'm wondering how much work it'd be? As for the suggestion you've got here, I think we should also add a description at least. We could constrain the ID (it's probably at least 0, right?), but it has less value here, I suppose.
But yeah, I like it! Just wondering how much time and effort it would take 🤔
|
Ok, we've decided that this only makes sense when parameters are numbers, in all other cases it's fair to assume they're strings. So, we'll only add them when needed (like in this case) and assume that when not present they're strings. |
gastonfournier
force-pushed
the
parameter-types
branch
from
3813b49
to
e1ecb9b
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Path types in our openapi are inferred as string (which is a sensible default). But we can be more specific and provide the right type for each parameter. This is one example of how we can do that
@thomasheartman WDYT?