Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup api #127

Merged
merged 16 commits into from
Jun 16, 2016
Merged

Cleanup api #127

merged 16 commits into from
Jun 16, 2016

Conversation

ivarconr
Copy link
Member

@ivarconr ivarconr commented May 1, 2016

(Still WIP)

  • Clean up the express code
    • All routes in separate folder
    • All db-code in separate folder
    • All config set up in one place, use nconfig or similar
    • All required config injected to routes (database abstraction injected from top)
    • initialize all stateful modules at top and inject (this will ease unit-testing)
  • Upgrade to Node 6 Node 5
  • upgrade all libraries to latest version
    • This does not include frontend-dep such as react, redux.
  • serve favicon

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 89.665% when pulling 116c565 on cleanup_api into 2118aff on master.

@ivarconr ivarconr mentioned this pull request May 1, 2016
10 tasks
@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 90.476% when pulling 0dc566c on cleanup_api into 2118aff on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.7%) to 93.072% when pulling 024020c on cleanup_api into 2118aff on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.7%) to 93.072% when pulling b642c92 on cleanup_api into 2118aff on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.8%) to 93.093% when pulling 8815314 on cleanup_api into 2118aff on master.

@ivarconr ivarconr merged commit 4c1b380 into master Jun 16, 2016
@ivarconr ivarconr deleted the cleanup_api branch June 16, 2016 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants