-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useStyles
, refactor into StyledComponents
and sx
#2606
Comments
Hey, @Tymek, can I take a shot at this? Seems like a good first issue to orient myself with the codebase. |
This can be worked on by multiple people. Pick couple of files, let us know in the comment, and go for it! :) Once small initial contribution is reviewed you can choose to do another batch, that's how I see it. |
Picking up: Will share PR shortly |
Please find the PR UserForm.tsx |
Changes for [issue](#2606) Co-authored-by: Nuno Góis <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
useStyles
/makeStyles()
is deprecated (See: https://mui.com/system/styles/basics/).We need to migrate to
styled
, or where it makes sense usesx
while keeping in mind performance tradeoffs.Examples
New syntax: https://github.com/Unleash/unleash/blob/228ddabf73411ce8837824de1e15fe58659896a8/frontend/src/component/addons/AddonForm/AddonForm.styles.tsx
Old syntax: https://github.com/Unleash/unleash/blob/228ddabf73411ce8837824de1e15fe58659896a8/frontend/src/component/admin/apiToken/ApiTokenForm/ApiTokenForm.styles.ts
The text was updated successfully, but these errors were encountered: