Skip to content

Commit

Permalink
fix: when backporting we don't want to push latest docker tag (#7961)
Browse files Browse the repository at this point in the history
Backporting fixes to old versions usually pushes the docker latest tag
as well. We only want to do this if the version we're releasing is the
latest
  • Loading branch information
gastonfournier authored Aug 22, 2024
1 parent 7a82cd5 commit 6a0dd6f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/docker_publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ on:
description: "Which version to release"
type: 'string'
required: true
is-latest-version:
description: Is this the latest version? If latest we'll update the version docker
required: true
type: boolean
default: true
workflow_dispatch:

jobs:
Expand Down Expand Up @@ -39,6 +44,7 @@ jobs:
with:
images: |
unleashorg/unleash-server
flavor: latest=${{ github.event.inputs.is-latest-version }}
tags: |
# only enabled for workflow dispatch except main (assume its a release):
type=semver,pattern={{ version }},enable=${{ github.event_name == 'workflow_dispatch' && github.ref != 'refs/heads/main' }},value=${{ inputs.version }}
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/publish-new-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ on:
required: true
type: boolean
default: true
update-version-function:
description: Should we update the version function to use this version?
is-latest-version:
description: Is this the latest version? If latest we'll update the version function, docker and npm latest
required: true
type: boolean
default: true
Expand Down Expand Up @@ -138,6 +138,7 @@ jobs:
secrets: inherit
with:
version: ${{ github.event.inputs.version }}
is-latest-version: ${{ github.event.inputs.is-latest-version == 'true' }}

publish-npm:
needs: build
Expand All @@ -154,7 +155,7 @@ jobs:

update-version-checker:
needs: publish-docker
if: ${{ github.event.inputs.update-version-function == 'true' }}
if: ${{ github.event.inputs.is-latest-version == 'true' }}
uses: ./.github/workflows/update_version_for_version_checker.yml
secrets: inherit
with:
Expand Down

0 comments on commit 6a0dd6f

Please sign in to comment.