This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
refactor: adapt to Vite #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
olav
approved these changes
May 5, 2022
Tymek
reviewed
May 5, 2022
nunogois
commented
May 5, 2022
| @@ -1,5 +1,6 @@ | |||
| import 'whatwg-fetch'; | |||
| import 'themes/app.css'; | |||
| import 'regenerator-runtime/runtime'; | |||
There was a problem hiding this comment.
Had to add this after the merge, since it seems like react-table uses regeneratorRuntime.
See similar relevant issue: TanStack/router#227
There was a problem hiding this comment.
OK. Something to remember to check on next major version update of react-table.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
https://trello.com/c/EbjaGycH
Changing from
react-scriptsto Vite may provide some DX-related improvements.Important files
Most of the other changes were due to snaps getting updated or tests being slightly adapted to Vitest.
Discussion points
Some tests related to
msware still failing with Vitest, even though the current implementation seems to match Vitest docs.