-
-
Notifications
You must be signed in to change notification settings - Fork 199
Terms of Use Overlay Improvements #1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks, @crhallberg. I like how this looks, but we might need a IIIF expert to weigh in on whether this solution is entirely acceptable. I think in many cases, the requiredStatement is going to include license information... but I think it's at least theoretically possible that the license information might be independent of the required statement. Not sure what the most appropriate behavior would be there, or how to decide what to do. One possible approach: check if the license URI is part of the required statement. If so, use the current behavior; if not, add a "License: [linked URI]" to the end. (Not sure if that's the best approach -- just brainstorming!) |
Yeah, I agree, it would be great to get someone with more IIIF experience to weigh in. Maybe we could share this PR in a relevant community or channel to get some feedback. I’m not an expert in this area either, so some extra eyes would definitely help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @crhallberg -- this new version seems more streamlined and less controversial (though more IIIF input might be helpful). In any case, one minor observation for now.
terms = requiredStatement.value; | ||
} | ||
if (!terms) { | ||
const license = this.helper.getLicense(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that getLicense
can potentially return a null value, so we should only construct the link below if we have a non-null license.
Uh oh!
There was an error while loading. Please reload this page.