-
Notifications
You must be signed in to change notification settings - Fork 412
Force mode arguments #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Force mode arguments #707
Conversation
b7b6de3
to
a87eb27
Compare
a87eb27
to
4f14e98
Compare
…hanges to account for changes in msg in PR (ros-industrial/ur_msgs#20)
to match updated service definition and to match the force mode interface of ROS2.
4f14e98
to
e6d3123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation has the same issues as #718: When this is used while the JTC is active, the robot will try to get back to the latest commanded configuration once force mode is disabled. We cannot merge it like this.
This will probably not get merged unless somebody picks up the work of moving this to a separate controller so that resource management can be done properly. This feature exists in the ROS 2 driver, we recommend to switching to that by now. I'll leave this PR open, as the feature as such is working and usable if precautions are taken (stop JTC before using this feature). |
add damping and gain scale arguments to ROS service call. These can be set with each force mode call when PR is implemented.
This is also dependent on PR for the service definition.