Skip to content

Force mode arguments #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

URJala
Copy link
Collaborator

@URJala URJala commented Jul 9, 2024

add damping and gain scale arguments to ROS service call. These can be set with each force mode call when PR is implemented.
This is also dependent on PR for the service definition.

@URJala URJala force-pushed the force_mode_arguments branch from b7b6de3 to a87eb27 Compare January 8, 2025 14:38
@urfeex urfeex force-pushed the force_mode_arguments branch from a87eb27 to 4f14e98 Compare February 24, 2025 14:47
@urfeex urfeex force-pushed the force_mode_arguments branch from 4f14e98 to e6d3123 Compare March 10, 2025 11:19
Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation has the same issues as #718: When this is used while the JTC is active, the robot will try to get back to the latest commanded configuration once force mode is disabled. We cannot merge it like this.

@urfeex urfeex added the wontfix This will not be worked on label Mar 24, 2025
@urfeex
Copy link
Member

urfeex commented Mar 24, 2025

This will probably not get merged unless somebody picks up the work of moving this to a separate controller so that resource management can be done properly.

This feature exists in the ROS 2 driver, we recommend to switching to that by now.

I'll leave this PR open, as the feature as such is working and usable if precautions are taken (stop JTC before using this feature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants