Description refactoring #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauch
force-pushed
the
description_refactoring
branch
from
922c20b to
48821c1
Compare
Author
|
Probably we need to branch out for iron, as well, since UniversalRobots/Universal_Robots_ROS2_Description#114 is only for rolling and will probably not be backported. |
fmauch
force-pushed
the
description_refactoring
branch
from
48821c1 to
1a3ef33
Compare
added 2 commits
December 19, 2023 21:58
This uses the ur_description without a ros2_control tag and adds an own one for gazebo classic.
fmauch
force-pushed
the
description_refactoring
branch
from
1a3ef33 to
d91b82e
Compare
VinDp
approved these changes
Dec 20, 2023
Contributor
VinDp
left a comment
VinDp
left a comment
There was a problem hiding this comment.
Tested and checked: seems good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes along UniversalRobots/Universal_Robots_ROS2_Description#114, hence the draft status.