Skip to content

Update controllers adding dt in to update as in ros2_control#171

Merged
destogl merged 2 commits intomainfrom
add-dt-in-controllers
Sep 22, 2021
Merged

Update controllers adding dt in to update as in ros2_control#171
destogl merged 2 commits intomainfrom
add-dt-in-controllers

Conversation

@destogl
Copy link
Copy Markdown
Contributor

@destogl destogl commented Sep 19, 2021

This PR is related/depends on merge on ros-controls/ros2_control#520 (and ros2_control/ros2_controllers#241)

Copy link
Copy Markdown
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small change

@destogl
Copy link
Copy Markdown
Contributor Author

destogl commented Sep 21, 2021

@livanov93 this seems to be working. Can you give it a try with testing?

@livanov93
Copy link
Copy Markdown
Contributor

@destogl It looks good. I can test it with ursim immediately. Hardware test will have to wait.

Copy link
Copy Markdown
Contributor

@livanov93 livanov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@destogl Tested with ursim on galactic. Works normally.

@destogl destogl merged commit a0b6965 into main Sep 22, 2021
@destogl destogl deleted the add-dt-in-controllers branch September 22, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants