Skip to content

Conversation

@fmauch
Copy link
Contributor

@fmauch fmauch commented Jun 28, 2023

Adds IO fields for setting and disabling force mode.

@fmauch
Copy link
Contributor Author

fmauch commented Jun 28, 2023

On a side note: I think, this PR again very well supports the issues raised in #52

@urmahp urmahp self-requested a review September 12, 2023 07:20
Copy link
Collaborator

@urmahp urmahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

However, currently we can only set the damping and gain scaling, when we create the UrDriver object and not during runtime and it will be possible to change these variables at runtime? It would probably make sense to add support for setting the variables at runtime in the client library.

@fmauch
Copy link
Contributor Author

fmauch commented Sep 12, 2023

Yes, that is true. But for the moment at least this doesn't affect the description.

@fmauch fmauch merged commit 85d2ad8 into UniversalRobots:ros2 Sep 12, 2023
@fmauch fmauch deleted the force_mode branch September 12, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants