Skip to content

Conversation

urrsk
Copy link
Member

@urrsk urrsk commented Mar 7, 2025

but also changed the default ip to be 192.168.56.1 like on the external control urcap for CB3 and E-series to support future testing.

This commit should also fix issue #6

version: '1.0.0',
lockChildren: false,
allowsChildren: false,
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
})
});

@EbbeFuglsang
Copy link
Collaborator

Adding the following to the "rules" section in .eslint:

"@typescript-eslint/no-explicit-any": "off",

Will make the linting run with fewer errors.

Copy link
Collaborator

@EbbeFuglsang EbbeFuglsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great❗

Some general things we could consider:

  • Make prettier or another formatter a more integrated part
  • Make sure linting runs without issues
  • Make a devcontainer where also the tests can run

Improving the usablity and information given on the application screen.
But also changed the default ip to be 192.168.56.1 to support future testing.
@urrsk urrsk force-pushed the applicationScreenUpdate branch from 58a4f10 to 5850426 Compare March 25, 2025 14:06
@urrsk urrsk requested a review from EbbeFuglsang March 25, 2025 14:07
Copy link
Collaborator

@EbbeFuglsang EbbeFuglsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EbbeFuglsang EbbeFuglsang merged commit a39544c into UniversalRobots:master Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants