-
Notifications
You must be signed in to change notification settings - Fork 7
Mainly changed the Application screen #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mainly changed the Application screen #7
Conversation
...nd/src/app/components/external-control-application/external-control-application.component.ts
Outdated
Show resolved
Hide resolved
version: '1.0.0', | ||
lockChildren: false, | ||
allowsChildren: false, | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}) | |
}); |
...tend/src/app/components/external-control-program/external-control-program.behavior.worker.ts
Outdated
Show resolved
Hide resolved
...tend/src/app/components/external-control-program/external-control-program.behavior.worker.ts
Outdated
Show resolved
Hide resolved
...tend/src/app/components/external-control-program/external-control-program.behavior.worker.ts
Outdated
Show resolved
Hide resolved
Adding the following to the "rules" section in .eslint: "@typescript-eslint/no-explicit-any": "off", Will make the linting run with fewer errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great❗
Some general things we could consider:
- Make prettier or another formatter a more integrated part
- Make sure linting runs without issues
- Make a devcontainer where also the tests can run
01b4219
to
58a4f10
Compare
Improving the usablity and information given on the application screen. But also changed the default ip to be 192.168.56.1 to support future testing.
58a4f10
to
5850426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
but also changed the default ip to be 192.168.56.1 like on the external control urcap for CB3 and E-series to support future testing.
This commit should also fix issue #6