Skip to content

Conversation

urrsk
Copy link
Member

@urrsk urrsk commented Sep 18, 2025

To avoid any impact of calling the scaling or damping methods if no change to these values are needed.

To avoid any impact of calling the scaling or damping methods
if no change to these values are needed.
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.10%. Comparing base (3b63610) to head (3d2935a).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   77.86%   77.10%   -0.77%     
==========================================
  Files          92       92              
  Lines        4166     4162       -4     
  Branches      461      461              
==========================================
- Hits         3244     3209      -35     
- Misses        684      714      +30     
- Partials      238      239       +1     
Flag Coverage Δ
start_ursim 82.15% <ø> (-2.04%) ⬇️
ur20-latest 75.60% <ø> (-0.13%) ⬇️
ur5-3.14.3 76.20% <ø> (+0.02%) ⬆️
ur5e-10.7.0 ?
ur5e-5.9.4 76.06% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fair and tested that it works properly.

@urfeex
Copy link
Member

urfeex commented Oct 6, 2025

The original problem was resolved by #383. Therefore closing this.

@urfeex urfeex closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants