Skip to content

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Jul 10, 2025

This is an alternative to #358.

It still needs tests, hence the draft status.

- ReverseInterface
- TrajectoryPointInterface
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.55%. Comparing base (289c747) to head (56154c3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/control/trajectory_point_interface.cpp 76.92% 0 Missing and 3 partials ⚠️
src/control/reverse_interface.cpp 50.00% 0 Missing and 1 partial ⚠️
src/ur/instruction_executor.cpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   78.15%   77.55%   -0.61%     
==========================================
  Files          92       92              
  Lines        4138     4161      +23     
  Branches      456      461       +5     
==========================================
- Hits         3234     3227       -7     
- Misses        674      695      +21     
- Partials      230      239       +9     
Flag Coverage Δ
start_ursim 81.95% <ø> (-2.06%) ⬇️
ur20-latest 75.61% <87.17%> (-0.07%) ⬇️
ur5-3.14.3 76.11% <87.17%> (-0.17%) ⬇️
ur5e-10.7.0 70.80% <82.75%> (-0.14%) ⬇️
ur5e-5.9.4 76.07% <87.17%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mathias31415 added a commit to b-robotized-forks/Universal_Robots_ROS2_Driver_MotionPrimitive that referenced this pull request Jul 15, 2025
@urfeex
Copy link
Member Author

urfeex commented Jul 16, 2025

Tests have been added by now, so I will mark this as ready. @mathias31415 as far as I can see, that implementation suits your usecase, right?

@urfeex urfeex marked this pull request as ready for review July 16, 2025 10:45
@urfeex urfeex requested a review from a team July 16, 2025 10:45
@mathias31415
Copy link

Tests have been added by now, so I will mark this as ready. @mathias31415 as far as I can see, that implementation suits your usecase, right?

Yes it suits my usecase, thanks a lot!

@urfeex urfeex merged commit 7967284 into UniversalRobots:master Jul 24, 2025
23 of 28 checks passed
@urfeex urfeex deleted the callback_lists branch July 24, 2025 08:39
mathias31415 added a commit to b-robotized-forks/Universal_Robots_ROS2_Driver_MotionPrimitive that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants